On Mon, Jun 04 2018 at 2:54pm -0400, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Jun 4, 2018 at 8:32 AM Mike Snitzer <snitzer@xxxxxxxxxx> wrote: > > > > - Export 2 swait symbols for use by the new DM writecache target. > > I am *EXTREMELY* unhappy with this. > > The swait interface is pure and utter garbage, and I thought we > already agreed to just have a big comment telling people not to use > them. > > That seems to not have happened. > > The swait() interfaces are pure and utter garbage because they have > absolutely horrid semantics that are very different from normal > wait-queues, and there has never been any sign that the swait users > are actually valid. > > In particular, existing users were using swait because of complete > garbage reasons, like the alleged "win" for KVM, which was just > because there was only ever one waiter anyway. > > Is the new writecache usage really worth it? > > Is it even *correct*? > > As mentioned, swait semantics are completely buggy, with "swake_up()" > not at all approximating a normal wake-up. It only wakes *one* user, > so it's more like an exclusive waiter, except it ends up alway > sassuming that every waiter is exclusive without any actual marker for > that. > > End result: the interface has some very subtle races, and I'm not at > all convinced that the new writecache code is aware of this. > > In particular, I see what appears to be a bug in writecache_map(): it > does a writecache_wait_on_freelist(), but it doesn't actually > guarantee that it will then use the slot that it was woken up for (it > just does a "continue", which might instead do a > writecache_find_entry(). > > So *another* thread that was waiting for a slot will now not be woken > up, and the thread that *was* woken up didn't actually use the > freelist entry that it was waiting for. > > This is *EXACTLY* the kind of code that should not use swait lists. > It's buggy, and broken. And it probably works in 99% of all cases by > pure luck, so it's hard to debug too. > > In other words: I'm not pulling this shit. I want people to be *VERY* > aware of how broken swait queues are. You are *not* to use them unless > you understand them, and I have yet to find a single person who does. > > No way in hell are we exporting that shit. Fair enough, we'll get it fixed up to use normal waitqueues for next merge window. Mikulas elected to use swait because of the very low latency nature of layering ontop of persistent memory. Use of "simple waitqueues" _seemed_ logical to me. Apologies for not being aware of just how nasty swait is. Wish there was more notice that the code is _that_ subtle... obviously I wouldn't have pestered Peter to try to prop up dm-writecache's (ab)use of swait. Mike -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
