Re: [PATCH] SLUB: Do not fallback to mininum order if __GFP_NORETRY is set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] SLUB: Do not fallback to mininum order if __GFP_NORETRY is set
From: Christopher Lameter <cl@xxxxxxxxx>
Date: Wed, 18 Apr 2018 10:11:06 -0500 (CDT)
Cc: Mike Snitzer <snitzer@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Pekka Enberg <penberg@xxxxxxxxxx>, linux-mm@xxxxxxxxx, dm-devel@xxxxxxxxxx, David Rientjes <rientjes@xxxxxxxxxx>, Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>
In-reply-to: <alpine.LRH.2.02.1804181102490.13213@file01.intranet.prod.int.rdu2.redhat.com>
References: <alpine.DEB.2.20.1804180944180.1062@nuc-kabylake> <alpine.LRH.2.02.1804181102490.13213@file01.intranet.prod.int.rdu2.redhat.com>
User-agent: Alpine 2.20 (DEB 67 2015-01-07)

On Wed, 18 Apr 2018, Mikulas Patocka wrote:

> No, this would hit NULL pointer dereference if page is NULL and
> __GFP_NORETRY is set. You want this:

You are right

Acked-by: Christoph Lameter <cl@xxxxxxxxx>

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

References:
- [PATCH] SLUB: Do not fallback to mininum order if __GFP_NORETRY is set
  - From: Christopher Lameter
- Re: [PATCH] SLUB: Do not fallback to mininum order if __GFP_NORETRY is set
  - From: Mikulas Patocka

Prev by Date: Re: [PATCH] SLUB: Do not fallback to mininum order if __GFP_NORETRY is set
Next by Date: Re: [PATCH] SLUB: Do not fallback to mininum order if __GFP_NORETRY is set
Previous by thread: Re: [PATCH] SLUB: Do not fallback to mininum order if __GFP_NORETRY is set
Next by thread: Re: [PATCH] SLUB: Do not fallback to mininum order if __GFP_NORETRY is set
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]