On Wed, 2018-03-14 at 12:46 -0500, Benjamin Marzinski wrote: > These unit tests do not get complete code coverage. Also, they don't > check for memory errors. To do this through unit tests, instead of > using valgrid, would require adding unit test specific compilation > defines to the code, and compiling a seperate unit-test version. > > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> I'm impressed, you went much further with cmocka than I did so far. Nice work. Reviewed-by: Martin Wilck <mwilck@xxxxxxxx> ... but this is pretty dense material. I'd appreciate a follow-up patch adding some comments about the more complex test cases to make them easier to understand. -- Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107 SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
