On Wed, 2018-03-14 at 12:46 -0500, Benjamin Marzinski wrote: > Only multipathd needs to worry about the multipath waiter code. There > is > no point in having remove_map_and_stop_waiter() or > remove_maps_and_stop_waiters() in libmultipath, since they should > never > be use outside of multipathd. > > Reviewed-by: Martin Wilck <mwilck@xxxxxxxx> > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> > +static void > +remove_map_and_stop_waiter(struct multipath *mpp, struct vectors > *vecs, > + int purge_vec) > +{ > + stop_waiter_thread(mpp, vecs); > + remove_map(mpp, vecs, purge_vec); > +} AFAICS remove_map_and_stop_waiter is always called with purge_vec == 1, so this could be further simplified. Could be a separate patch though. -- Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107 SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel