Hi Bart, On 2017-12-12 16:28, Bart Van Assche wrote: > I agree that we need a way to specify additional compilation flags. However, is > OPTFLAGS really a standard? Aren't most developers used to set CFLAGS to specify > additional compilation flags? When I created the patch I searched in the source code of other projects after "OPTFLAGS" usage and came to the conclusion that this isn't a standard. However, my patch shouldn't break any existing use cases. So my understanding was that "OPTFLAGS" is used like the default set of flags in case the user hasn't set any flags on its own. However, the project may still need to add a special flag which should be set everywhere. That's why I created the patch the way I did: 1) User can provide own CFLAGS in which case the default set of flags (OPTFLAGS) aren't used. 2) We now extend set CFLAGS by adding our additional flags (-DRUN_DIR..) we want to be set everywhere. Your patch will do the same but require downstream to unset/negate default flags. I don't really care if we pick your patch or my patch. -- Regards, Thomas Deutschmann / Gentoo Linux Developer C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5
Attachment:
signature.asc
Description: OpenPGP digital signature
-- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
