On Thu, 2017-11-30 at 00:23 +0100, Thomas Deutschmann wrote:
> The Makefile overrides standard envvars that control the toolchain flags.
> This patch should set things right without reducing default behavior.
>
> Signed-off-by: Thomas Deutschmann <whissi@xxxxxxxxxx>
> ---
> Makefile.inc | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile.inc b/Makefile.inc
> index 29c290a2..951d58fc 100644
> --- a/Makefile.inc
> +++ b/Makefile.inc
> @@ -90,11 +90,12 @@ OPTFLAGS = -O2 -g -pipe -Wall -Wextra -Wformat=2 -Werror=implicit-int \
> -Wp,-D_FORTIFY_SOURCE=2 $(STACKPROT) \
> --param=ssp-buffer-size=4
>
> -CFLAGS = $(OPTFLAGS) -DLIB_STRING=\"${LIB}\" -DRUN_DIR=\"${RUN}\"
> +CFLAGS ?= $(OPTFLAGS)
> +CFLAGS += -DLIB_STRING=\"${LIB}\" -DRUN_DIR=\"${RUN}\"
> BIN_CFLAGS = -fPIE -DPIE
> LIB_CFLAGS = -fPIC
> SHARED_FLAGS = -shared
> -LDFLAGS = -Wl,-z,relro -Wl,-z,now
> +LDFLAGS += -Wl,-z,relro -Wl,-z,now
> BIN_LDFLAGS = -pie
>
> # Check whether a function with name $1 has been declared in header file $2.
Hello Thomas,
I agree that we need a way to specify additional compilation flags. However, is
OPTFLAGS really a standard? Aren't most developers used to set CFLAGS to specify
additional compilation flags?
Bart.
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
