Hi, On 05/04/17 00:35, Brian Norris wrote: > On Tue, Mar 28, 2017 at 03:31:51PM -0400, Mike Snitzer wrote: >> On Tue, Mar 28 2017 at 2:31pm -0400, >> Brian Norris <briannorris@xxxxxxxxxxxx> wrote: >> >>> If anyone is going to use dm_table_create(), they probably should be >>> able to use dm_table_destroy() too. Move the dm_table_destroy() >>> definition outside the private header, near dm_table_create() >>> >>> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx> >> >> Not seeing why we need dm_table_create() exposed. So I think you went >> the wrong way with this. Unless you have an actual need, I'd prefer to >> see dm_table_create() moved from include/linux/device-mapper.h to >> drivers/md/dm.h > > We've been carrying code in our ChromeOS kernel to parse a cmdline arg > for setting up early DM maps -- e.g., a dm-verity rootfs without using > an initramfs. We currently use dm_table_create() from init/*.c (and we > *should* be using dm_table_destroy() in the error paths). So I'm > certainly not going to send the patch to do the reverse :) > > Enric is working on cleaning up this work to send here, so if you don't > want to see this patch now, you may well see it later. > As Brian told you we have a use case that uses the dm_table_create and others from init/*.c, I expect have a first patches during this week, if it's ok I'll include this patch in my patchset so you have the overall of what we are talking about. Cheers, Enric > Brian > -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
