>>>>> "Christoph" == Christoph Hellwig <hch@xxxxxx> writes: Christoph, Christoph> This mirrors the blk-mq capabilities to allocate extra Christoph> drivers-specific data behind struct request by setting a Christoph> cmd_size field, as well as having a constructor / destructor Christoph> for it. Nice! A couple of minor nits: +static void *alloc_request_size(gfp_t gfp_mask, void *data) I like alloc_request_simple() but alloc_request_size() seems a bit contrived. _reserve? _extra? _special? Don't have any good suggestions, I'm afraid. Also a bit heavy on the else brackets a couple of places. But no biggie. Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
