On 02/03/2016 07:24 PM, Mike Snitzer wrote: > On Wed, Feb 03 2016 at 1:04pm -0500, > Mike Snitzer <snitzer@xxxxxxxxxx> wrote: > >> I'm still not clear on where the considerable performance loss is coming >> from (on null_blk device I see ~1900K read IOPs but I'm still only >> seeing ~1000K read IOPs when blk-mq DM-multipath is layered ontop). >> What is very much apparent is: layering dm-mq multipath ontop of null_blk >> results in a HUGE amount of additional context switches. I can only >> infer that the request completion for this stacked device (blk-mq queue >> ontop of blk-mq queue, with 2 completions: 1 for clone completing on >> underlying device and 1 for original request completing) is the reason >> for all the extra context switches. > > Starts to explain, certainly not the "reason"; that is still very much > TBD... > >> Here are pictures of 'perf report' for perf datat collected using >> 'perf record -ag -e cs'. >> >> Against null_blk: >> http://people.redhat.com/msnitzer/perf-report-cs-null_blk.png > > if dm-mq nr_hw_queues=1 and null_blk nr_hw_queues=1 > cpu : usr=25.53%, sys=74.40%, ctx=1970, majf=0, minf=474 > if dm-mq nr_hw_queues=1 and null_blk nr_hw_queues=4 > cpu : usr=26.79%, sys=73.15%, ctx=2067, majf=0, minf=479 > >> Against dm-mpath ontop of the same null_blk: >> http://people.redhat.com/msnitzer/perf-report-cs-dm_mq.png > > if dm-mq nr_hw_queues=1 and null_blk nr_hw_queues=1 > cpu : usr=11.07%, sys=33.90%, ctx=667784, majf=0, minf=466 > if dm-mq nr_hw_queues=1 and null_blk nr_hw_queues=4 > cpu : usr=15.22%, sys=48.44%, ctx=2314901, majf=0, minf=466 > > So yeah, the percentages reflected in these respective images didn't do > the huge increase in context switches justice... we _must_ figure out > why we're seeing so many context switches with dm-mq. > Well, the most obvious one being that you're using 1 dm-mq queue vs 4 null_blk queues. So you will have have to do an additional context switch for 75% of the total I/Os submitted. Have you tested with 4 dm-mq hw queues? To avoid context switches we would have to align the dm-mq queues to the underlying blk-mq layout for the paths. And we need to look at making the main submission path lockless; I was wondering if we really need to take the lock if we don't switch priority groups; maybe we can establish a similar algorithm blk-mq does; if we were to have a queue per valid path in any given priority group we should be able to run lockless and only take the lock if we need to switch priority groups. But anyway, I'll be looking at your patches. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
