On Mon, Oct 17, 2011 at 12:22:13PM -0400, Mikulas Patocka wrote: > > thinp uses dm_bufio_release_move() and write_callback. So yes, this > > is a bug fix. I thought so and merged. > > BTW. it still uses the old block number in "prepare_for_write" callback. > Do you use this block number somewhere? Should we link the buffer to the > new block before the call and the link it back? I double checked this; it's fine. I use release_move as part of the shadow operation in the transaction manager. As such we know a write lock is going to be grabbed on it straight away (which will dirty and prompt a rewriting of the block nr). Also in the event of a crash before the next commit, the new block wont appear in the metadata at all. - Joe -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel