On 2011-09-11 16:51, Christoph Hellwig wrote: > There is very little benefit in allowing to let a ->make_request > instance update the bios device and sector and loop around it in > __generic_make_request when we can archive the same through calling > generic_make_request from the driver and letting the loop in > generic_make_request handle it. Agree, this looks good! Will apply for 3.2. > Note that various drivers got the return value from ->make_request and > returned non-zero values for errors. Hadn't noticed that, I guess the return values are easy to get wrong in that case. Never a good sign. -- Jens Axboe -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
