On Thu, Aug 18 2011 at 6:31pm -0400, Mikulas Patocka <mpatocka@xxxxxxxxxx> wrote: > > This all sounds good; get the locking interface in and I'll switch to > > bufio straight away. > > > > - Joe > > I uploaded bufio-based block manager at > http://people.redhat.com/mpatocka/patches/kernel/dm-thinp-bufio/. It > supports locks, but it defines new functions down_write_non_owner and > up_write_non_owner. dm-bufio.patch: drivers/md/Kconfig needs a more comprehensive description for DM_BUFIO's help. dm-thinp-bufio.patch: 1) This drivers/md/persistent-data/dm-block-manager.h change avoids lots of block manager interface churn: -struct dm_block; +#define dm_block dm_buffer +#define dm_block_manager dm_bufio_client But I think it'd be best, in the long run, to have a follow-on patch that does away with the aliases and just use the bufio structs throughout the code. Anyway, don't need to worry about this now. But what you've done is hack that should probably be cleaned up. 2) dm_bm_rebind_block_device: + * !!! FIXME: remove this. It is supposedly unused. I'll need to look closer at the overall changes to dm-block-manager.c but you've clearly gotten rid of struct dm_block_manager; so there is no reference to a bdev that needs to be flushed. Which begs the question: Have you tested this bufio conversion with the thinp-test-suite? git://github.com/jthornber/thinp-test-suite.git Question for Joe: You're making conflicting changes quick enough that I wonder if you and Mikulas will ever converge (e.g. why do multiple block managers need to have access to the same metadata device!?). - - [ ] Sometimes I'm getting kmem_cache name clashes in the block + - [X] Sometimes I'm getting kmem_cache name clashes in the block manager. We're obviously not deleting the cache in a particular error path. Recently introduced. :ejt: commit 049bf17f41147ba3d51bac6ebee038d3d79a086c Author: Joe Thornber <ejt@xxxxxxxxxx> Date: Wed Aug 17 13:46:12 2011 +0100 [block-manager, thin-metadata] Make the bm kmemcache name unique to the pool. ATM the kmem_cache identifier just includes the major/minor of the device that the bm is looking at. This means you can't create 2 bms that point to the same device without generating a nasty stack trace. This patch makes the name unique to the pool. It's a quick hack to allow me to keep on testing. Could someone who cares about these kmemcaches decide on a proper solution please. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
