On Wed, 4 May 2011, Ted Ts'o wrote: > On Fri, Apr 29, 2011 at 09:28:51AM -0500, Eric Sandeen wrote: > > On 4/29/11 7:29 AM, Christoph Hellwig wrote: > > > FYI, that disable discard on failure seems to be an ext4 special and no > > > one else picked up that stupid idea. If ext4 wants to misbehave for > > > that just let them.. > > > > It was my "stupid idea," and I'm ok with reverting it ;) > > I think I forgot to send the patch out, but it's been reverted in the > ext4 master branch, commit id: d9f34504e695. It's more than a revert, > actually, since I also dropped error checking for FITRIM. Otherwise > an attempt to use FITRIM would stop after hitting the first dm region > that didn't support discards. > > - Ted > However I would very much like to change blkdev_issue_discard() not NOT return EOPNOTSUPP if QUEUE_FLAG_DISCARD is set, this way we can rely on EOPNOTSUPP saying really that it is NOT supported. Regardless on ext4 change. I will send a patch for it, if you guy agree. Also consider BLKDISCARD which is now broken and this change will fix that! Thanks! -Lukas -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
