Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Fri, 29 Apr 2011 09:28:51 -0500
Cc: Mike Snitzer <snitzer@xxxxxxxxxx>, dm-devel@xxxxxxxxxx, DarkNovaNick@xxxxxxxxx, linux-lvm@xxxxxxxxxx, Lukas Czerner <lczerner@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx
In-reply-to: <20110429122906.GA7381@xxxxxxxxxxxxx>
References: <20110412234706.GA11244@xxxxxxxxxx> <20cf301cbef67d323104a0c2ff52@xxxxxxxxxx> <20110413224025.GA18589@xxxxxxxxxx> <20110413234854.GA19793@xxxxxxxxxx> <20110426173213.GA19604@xxxxxxxxxx> <20110428001912.GA14659@xxxxxxxxxx> <20110428075355.GA2190@xxxxxxxxxxxxx> <20110428205935.GA24979@xxxxxxxxxx> <alpine.LFD.2.00.1104291117510.5496@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20110429122454.GL32370@xxxxxxxxxxxxxxxxxxxxx> <20110429122906.GA7381@xxxxxxxxxxxxx>
Reply-to: device-mapper development <dm-devel@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9

On 4/29/11 7:29 AM, Christoph Hellwig wrote:
> FYI, that disable discard on failure seems to be an ext4 special and no
> one else picked up that stupid idea.  If ext4 wants to misbehave for
> that just let them..

It was my "stupid idea," and I'm ok with reverting it ;)

-Eric
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

Follow-Ups:
- Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Ted Ts'o

References:
- [PATCH] dm snapshot: add discard support to the snapshot-origin target [was: Re: Testing TRIM with LVM]
  - From: Mike Snitzer
- Re: dm snapshot: add discard support to the snapshot-origin target [was: Re: Testing TRIM with LVM]
  - From: Mike Snitzer
- Re: dm snapshot: add discard support to the snapshot-origin target [was: Re: Testing TRIM with LVM]
  - From: Mike Snitzer
- [PATCH] dm snapshot: ignore discards issued to the snapshot-origin target
  - From: Mike Snitzer
- Re: [PATCH] dm snapshot: ignore discards issued to the snapshot-origin target
  - From: Christoph Hellwig
- do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Mike Snitzer
- Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Lukas Czerner
- Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Alasdair G Kergon
- Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Christoph Hellwig

Prev by Date: Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
Next by Date: Re: Soft lockup during suspend since ~2.6.36 [bisected]
Previous by thread: Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
Next by thread: Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]