Re: [linux-lvm] do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [linux-lvm] do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
From: Alasdair G Kergon <agk@xxxxxxxxxx>
Date: Fri, 29 Apr 2011 00:11:08 +0100
Cc: Mike Snitzer <snitzer@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, dm-devel@xxxxxxxxxx, DarkNovaNick@xxxxxxxxx, LVM general discussion and development <linux-lvm@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx
In-reply-to: <4DB9F1BE.7090208@xxxxxxxxxx>
Mail-followup-to: Eric Sandeen <sandeen@xxxxxxxxxx>, LVM general discussion and development <linux-lvm@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, dm-devel@xxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, DarkNovaNick@xxxxxxxxx
Organization: Red Hat UK Ltd. Registered in England and Wales, number 03798903. Registered Office: Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE.
References: <20cf301cbef67d323104a0c2ff52@xxxxxxxxxx> <20110413224025.GA18589@xxxxxxxxxx> <20110413234854.GA19793@xxxxxxxxxx> <20110426173213.GA19604@xxxxxxxxxx> <20110428001912.GA14659@xxxxxxxxxx> <20110428075355.GA2190@xxxxxxxxxxxxx> <20110428205935.GA24979@xxxxxxxxxx> <4DB9DBF1.9060901@xxxxxxxxxx> <20110428225945.GG32370@xxxxxxxxxxxxxxxxxxxxx> <4DB9F1BE.7090208@xxxxxxxxxx>
Reply-to: device-mapper development <dm-devel@xxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)

On Thu, Apr 28, 2011 at 06:01:18PM -0500, Eric Sandeen wrote:
> If you are saying that a target should return EOPNOTSUPP when it does not support the operation, then we are in violent agreement.   :)
 
Naturally, with the definition you used in the first post.
(I.e. if the target does *anything* with it, you do not get that error, even
if it did not process it completely.)

Alasdair

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

References:
- [PATCH] dm snapshot: add discard support to the snapshot-origin target [was: Re: Testing TRIM with LVM]
  - From: Mike Snitzer
- Re: dm snapshot: add discard support to the snapshot-origin target [was: Re: Testing TRIM with LVM]
  - From: Mike Snitzer
- Re: dm snapshot: add discard support to the snapshot-origin target [was: Re: Testing TRIM with LVM]
  - From: Mike Snitzer
- [PATCH] dm snapshot: ignore discards issued to the snapshot-origin target
  - From: Mike Snitzer
- Re: [PATCH] dm snapshot: ignore discards issued to the snapshot-origin target
  - From: Christoph Hellwig
- do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Mike Snitzer
- Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Eric Sandeen
- Re: [linux-lvm] do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Alasdair G Kergon
- Re: [linux-lvm] do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
  - From: Eric Sandeen

Prev by Date: Re: [linux-lvm] do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
Next by Date: Re: Soft lockup during suspend since ~2.6.36 [bisected]
Previous by thread: Re: [linux-lvm] do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
Next by thread: Re: do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]