>>>>> "Mike" == Mike Snitzer <snitzer@xxxxxxxxxx> writes: [Stacking drivers having to set the queue flag] Mike> But that was already done properly, so that wasn't a problem that Mike> needed fixing (it just had potential to be overlooked if/when Mike> there is a new stacking driver). Yeah, just elaborating that the existing approach is flawed for several reasons. I don't know what happened to the wrapper function that set both flags. I must have botched it when the topology code got merged. Mike> It took me a bit to see exactly where we got it wrong. Looks like Mike> __scsi_alloc_queue was only concerned with the queue flag. So a Mike> minimalist fix would've been to also set no_cluster = 1 in Mike> __scsi_alloc_queue? Yep. But I'd rather fix this up the right way instead of perpetuating the ugly two-flag monte. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
