>>>>> "Mike" == Mike Snitzer <snitzer@xxxxxxxxxx> writes: Mike> But even with your blk_off_t patch (and prior to it with sector_t) Mike> you're mixing int with blk_off_t in blk_stack_limits() by doing: Mike> alignment = queue_limit_alignment_offset(b, offset); Mike> This helped motivate my "blind" conversion. Yeah. However, that particular wart is fixed by an unrelated patch in my queue wrt. discard alignment. But I wanted something you guys could look at that applied on top of upstream. I'm tinkering with a few things on this end to see if I can make the distinction between an offset and an alignment obvious. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
