>>>>> "Mike" == Mike Snitzer <snitzer@xxxxxxxxxx> writes: Mike, Mike> After looking closer there seems to be various type Mike> inconsistencies in the alignment_offset and discard_alignment Mike> related routines (returning 'int' in places, etc). Mike> The following patch is what I found; I have no problem with Mike> switching from 'unsigned long' to blk_off_t for LBD though. I only use blk_off_t in the places where we're dealing with absolute offsets. Blindly converting alignment_offset from int to unsigned long won't work. We depend on being able to return -1 in case of misalignment. Hence int and not unsigned int. Furthermore, the returned values are always modulo the granularity so int is plenty big. So NAK from here. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
