> On Fri, 2009-10-02 at 16:04 -0600, Moger, Babu wrote: > > Chandra, I have one comment on this patch.. > > > > > static inline int scsi_dh_handler_exist(const char *name) > > > Index: linux-2.6.31/drivers/scsi/device_handler/scsi_dh.c > > > =================================================================== > > > --- linux-2.6.31.orig/drivers/scsi/device_handler/scsi_dh.c > > > +++ linux-2.6.31/drivers/scsi/device_handler/scsi_dh.c > > > @@ -214,7 +214,7 @@ store_dh_state(struct device *dev, struc > > > * Activate a device handler > > > */ > > > if (scsi_dh->activate) > > > - err = scsi_dh->activate(sdev); > > > + err = scsi_dh->activate(sdev, NULL, NULL); > > > > > > This might cause problems in handlers. We don’t do NULL check in > attach routine. > > I assume you meant activate(), when you mention "attach" above. > > At every place where the callback function is called, we first check > that the callback function is not NULL. > > Can you point me if I missed some place. > Sorry for the confusion.. Yes, I meant activate. You are right. All the handlers check for NULL before calling. We are good here.. I misread the code.. -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
