Vivek Goyal wrote: ... > + > +static void elv_preempt_queue(struct request_queue *q, struct io_queue *ioq) > +{ > + elv_log_ioq(q->elevator->efqd, ioq, "preempt"); > + elv_slice_expired(q); > + > + /* > + * Put the new queue at the front of the of the current list, > + * so we know that it will be selected next. > + */ > + > + requeue_ioq(ioq); > + ioq->slice_start = ioq->slice_end = 0; I think this assignment is redundant because these two members will be reset when this ioq is scheduled. Signed-off-by: Gui Jianfeng <guijianfeng@xxxxxxxxxxxxxx> --- block/elevator-fq.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/block/elevator-fq.c b/block/elevator-fq.c index d04e925..b3c387d 100644 --- a/block/elevator-fq.c +++ b/block/elevator-fq.c @@ -2650,7 +2650,6 @@ static void elv_preempt_queue(struct request_queue *q, struct io_queue *ioq) */ requeue_ioq(ioq); - ioq->slice_start = ioq->slice_end = 0; elv_mark_ioq_slice_new(ioq); } } -- 1.5.4.rc3 -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel