Chandra Seetharaman wrote:
Hi Hannes, Now I see why you want this change in dm-multipath. I think I agree with these changes.
Ah. good.
But, it brings another question: what does dh_state provide ? Help to user to see which hardware handler a device is attached to ?
And allowing to attach to a different hardware handler. Not everyone is running multipathing, but might be interested in the having the device handler nevertheless.
I thought more about the scsi_dh_detach function (in the context of my earlier comment), adding it would require more housekeeping to associate one-to-one mapping between attach and detach. We can leave it the same way as the module will be detached when the device disappear eventually.
Why? You can detach with dh_state, too; just do an echo detach > /sys/block/sdX/device/dh_state and the hardware handler will detach. So no additional attribute is required. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
