Chandra Seetharaman wrote:
I do not know the functionality of this module. So, my comments are only related to code. blk_request_rq() frees up the request before it returns (in blk_end_sync_rq()). So, there is no need for blk_put_request().
Indeed. But this opens up another question: By the time blk_execute_rq() returns, the request is already put back onto the queue. That means that I shouldn't access rq->errors any more, as the request might have been reused already. But blk_execute_rq() returns -EIO for any error, making it impossible to signal a proper error here. So how do I get the contents of rq->errors safely? Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
