We dereference bitmap both one line above and one line below this check
rendering this check quite useless.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
--- linux-2.6.16-rc5-mm3-full/drivers/md/bitmap.c.old 2006-03-10 19:02:38.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/drivers/md/bitmap.c 2006-03-10 19:02:54.000000000 +0100
@@ -546,7 +546,7 @@ static void bitmap_mask_state(struct bit
unsigned long flags;
spin_lock_irqsave(&bitmap->lock, flags);
- if (!bitmap || !bitmap->sb_page) { /* can't set the state */
+ if (!bitmap->sb_page) { /* can't set the state */
spin_unlock_irqrestore(&bitmap->lock, flags);
return;
}
--
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
