Hi Samuel,
> Le 22 oct. 2015 à 17:44, Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> a écrit :
>
...
>>>> +enum nfcmrvl_phy {
>>>> + NFCMRVL_PHY_USB = 0,
>>>> + NFCMRVL_PHY_UART = 1,
>>>> + NFCMRVL_PHY_I2C = 2,
>>>> + NFCMRVL_PHY_SPI = 3,
>>>> +};
>>> Why is that part of the fw_dld header ?
>>
>> Because this information is given by the FW header inside the firmware binary. This is used to ensure that the firmaware used was configured for the current phy interface.
> Sure. But can we keep it in the nfcmrvl.h header ?
Ok.
>>>> @@ -185,6 +202,11 @@ int nfcmrvl_nci_recv_frame(struct nfcmrvl_private *priv, struct sk_buff *skb)
>>>> }
>>>> }
>>>>
>>>> + if (priv->ndev->nfc_dev->fw_download_in_progress) {
>>> Who's setting that flag to true ?
>>
>> This is done by core code (check nfc_fw_download function in net/nfc/core.c).
> Duh. Sorry for the brain fart...
No problem
Br,
--
Vincent--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
