Hi Vincent, On Wed, Oct 21, 2015 at 10:12:06PM +0000, Vincent Cuissard wrote: > Hi Samuel, > > >> Le 21 oct. 2015 à 07:57, Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> a écrit : > >> > >> Hi Vincent, > >> > >>> On Mon, Sep 28, 2015 at 02:33:07PM +0200, Vincent Cuissard wrote: > >>> Export nci_send_frame symbol to allow drivers to use it. > >>> This is needed for example if NCI is used during firmware > >>> download phase. > >> If what you need is a way to directly send completely custom frames then > >> I'd prefer that you export a routine that puts such frame on the > >> cmd_q skb queue and schedule the cmd_work work. > > > > I need this to send frames over our proprietary logical connection for fw download. > > > > I will check if I can use the conn create and nci_send_cmd. > > I have checked. I should be able to use nci_send_cmd without hacking the whole code. For logical connection I still need nci_send_frame because related APIs are synchrounous and not designed to be used when device is not up. I tried to tweak this but the code became too ugly since in my driver I got to forward some packets to core RX while keeping handling others in my workqueue. The code was really unreadable. > > I will send a v3 with nci_send_cmd usage. > > BTW, keep in mind that this fw download code is a proprietary protocol based on NCI style frames. I tried to reuse all generic functions but I don't want to complexify the driver and the core part for such proprietary stuff. > Sure. The idea is to make it simpler and less error prone by avoiding code duplication, not the other way around. Cheers, Samuel. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
