Thanks for review.
On 2015/10/20 17:00, Arnd Bergmann wrote:
> On Tuesday 20 October 2015 16:45:24 Chen Feng wrote:
>> +
>> + smmu@f4210000 {
>
> I think the canonical name for an IOMMU device is 'iommu', not 'smmu'.
Accept.
>
>> + compatible = "hisilicon,hi6220-smmu";
>> + reg = <0x0 0xf4210000 0x0 0x1000>;
>> + interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&sys_ctrl HI6220_MMU_CLK>,
>> + <&media_ctrl HI6220_MED_MMU>,
>> + <&sys_ctrl HI6220_MEDIA_PLL_SRC>;
>> + clock-names = "smmu_clk",
>> + "media_sc_clk",
>> + "smmu_peri_clk";
>
>
> Better avoid underscores in strings, and drop the "_clk" postfix in
> the clock names.
>
> I did not receive patch 1/3 this time, but I see in version 1, that
> you forgot to document the strings:
>
Accept, I will change this.
>> +- clock-names: The name to enable clock with clock framework.
>
> This needs to list the names of the clock inputs to the smmu.
>
> Arnd
> _______________________________________________
> linuxarm mailing list
> linuxarm@xxxxxxxxxx
> http://rnd-openeuler.huawei.com/mailman/listinfo/linuxarm
>
> .
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
