Hi Jisheng, On Fri, Oct 09, 2015 at 05:22:38PM +0800, Jisheng Zhang wrote: > On Fri, 9 Oct 2015 11:03:53 +0200 > Antoine Tenart <antoine.tenart@xxxxxxxxxxxxxxxxxx> wrote: > > > > Finally you can move the OF dependency to the PINCTRL_BERLIN config as > > all Berlin pinctrl drivers depends on it. > > PINCTRL_BERLIN isn't user visible and it's selected by PINCTRL_BERLIN_BG4CT. So > we may have the following random config case: > > CONFIG_OF=n > CONFIG_PINCTRL_BERLIN_BG4CT=y > > In this case, there will be build errors for we missed OF. So we have to > make PINCTRL_BERLIN_BG4CT depends on OF. What do you think? Or is there > better solution? That's true. But because other Berlin pinctrl drivers also depends on CONFIG_OF, we need to make then depend on it too. This isn't the topic of this series so I'll send a separate patch later. Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
