Stephen Boyd <sboyd@xxxxxxxxxxxxxx> writes: > On 09/28, Eric Anholt wrote: >> + >> +static const char *bcm2835_clock_per_parents[] = { >> +static const char *bcm2835_clock_vpu_parents[] = { >> +static const char *bcm2835_clock_osc_parents[] = { > > Can these parent arrays be const char * const ? They couldn't because I was editing them in place to do the s/"xosc"/of_clk_get_parent_name()/ edit. I've moved the edit to being in a stack allocation at probe time. I think I've done all of your suggested changes in the new version (and explained the extra ana2 read/write).
Attachment:
signature.asc
Description: PGP signature