Hello Krzysztof, On 09/30/2015 09:08 AM, Krzysztof Kozlowski wrote: > On 30.09.2015 16:06, Javier Martinez Canillas wrote: >> Hello, >> >> On 09/30/2015 09:02 AM, Krzysztof Kozlowski wrote: >>> On 30.09.2015 15:58, Kukjin Kim wrote: >> >> [snip] >> >>>>> >>>>> Could you add the new compatible and fix patch issues pointed by Doug? >>>>> >>>> Documenting for the compatibles would be required even I already applied >>>> its updated patch... >>> >> >> Kukjin, I agree that they should be documented but I thought it would >> be a separate patch since currently we don't document any board. >> >>> What do you mean by "documenting compatibles"? These are board >>> compatibles, they are not documented... >>> >> >> Krzysztof, I've on my TODO list to add a file describing all Exynos >> platforms and DT bindings, something like what other SoC do, i.e: >> >> Documentation/devicetree/bindings/arm/omap/omap.txt >> Documentation/devicetree/bindings/arm/rockchip.txt > > Right, that's a good idea. However lack of it does not affect current > work because compatibles for Exynos board are not documented at all. > Agreed. That's why I didn't add it, even when checkpatch.pl complains: WARNING: DT compatible string "google,snow-rev5" appears un-documented -- check ./Documentation/devicetree/bindings/ > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html