On Wed, Sep 23, 2015 at 11:14:56AM +0300, Laurentiu Palcu wrote: > Hi, > > On Wed, Sep 23, 2015 at 02:34:15AM +0200, Sebastian Reichel wrote: > > Hi, > > > > On Tue, Sep 22, 2015 at 04:58:24PM -0500, Andreas Dannenberg wrote: > > > On Tue, Sep 22, 2015 at 06:24:48PM +0200, Sebastian Reichel wrote: > > > > On Fri, Sep 18, 2015 at 04:39:49PM -0500, Andreas Dannenberg wrote: > > > > > Extend the bq24257 charger's device tree documentation to cover the > > > > > bq24250 and bq24251 devices as well feature additions. > > > > > > > > The binding looks fine to except for: > > > > > > > > > +- stat-gpios: GPIO used for the devices STAT_IN pin. Alternatively the pin can > > > > > + also be defined through the standard interrupt definition properties (see > > > > > + optional properties section below). Only use one method. > > > > > > > > Why do you expose two ways for this? > > > > > > Hi Sebastian. The original driver exposed this - it just didn't > > > document it in the DT binding doc. I'm not sure why this was introduced > > > in the first place (Laurentiu?). I know we can't change the API but > > > since it was never documented maybe we can remove it? > > > > It seems this is neither documented, nor used. So I guess it can be > > removed. Let's wait for feedback from Laurentiu, though. > This was needed to have both ACPI and DT enumeration work. At the time I > wrote the driver, GpioInt resources in ACPI were not passed to the > driver in client->irq, as opposed to DT enumeration. > > However, conveniently enough, the patch below landed in master by the > same time bq24257 driver went in. So, I believe it should be safe now to > remove the stat-gpio probing. > > commit 845c877009cf014b971aab7f54613f9185a824b0 > Author: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > Date: Wed May 6 13:29:08 2015 +0300 > > i2c / ACPI: Assign IRQ for devices that have GpioInt automatically > Thanks for the background! I'll be happy to simplify this as part of my patch series. -- Andreas Dannenberg Texas Instruments Inc -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
