Re: [PATCH v5 01/11] dt: power: bq24257-charger: Cover additional devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi,

On Tue, Sep 22, 2015 at 04:58:24PM -0500, Andreas Dannenberg wrote:
> On Tue, Sep 22, 2015 at 06:24:48PM +0200, Sebastian Reichel wrote:
> > On Fri, Sep 18, 2015 at 04:39:49PM -0500, Andreas Dannenberg wrote:
> > > Extend the bq24257 charger's device tree documentation to cover the
> > > bq24250 and bq24251 devices as well feature additions.
> > 
> > The binding looks fine to except for:
> > 
> > > +- stat-gpios: GPIO used for the devices STAT_IN pin. Alternatively the pin can
> > > +    also be defined through the standard interrupt definition properties (see
> > > +    optional properties section below). Only use one method.
> > 
> > Why do you expose two ways for this?
> 
> Hi Sebastian. The original driver exposed this - it just didn't
> document it in the DT binding doc. I'm not sure why this was introduced
> in the first place (Laurentiu?). I know we can't change the API but
> since it was never documented maybe we can remove it?

It seems this is neither documented, nor used. So I guess it can be
removed. Let's wait for feedback from Laurentiu, though.

-- Sebastian

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux