Re: [PATCH v2 2/3] soc: brcmstb: Add Bus Interface Unit control setup

[Florian Fainelli <f.fainelli@xxxxxxxxx>]

On 16/09/15 23:08, Gregory Fong wrote:
>> [...]
>> diff --git a/drivers/soc/brcmstb/biuctrl.c b/drivers/soc/brcmstb/biuctrl.c
>> new file mode 100644
>> index 000000000000..1d4deada1c4d
>> --- /dev/null
>> +++ b/drivers/soc/brcmstb/biuctrl.c
>> @@ -0,0 +1,119 @@
>> [...]
>> +int __init brcmstb_biuctrl_init(void)
>> +{
>> +       int ret = 0;
>> +
>> +       ret = setup_hifcpubiuctrl_regs();
>> +       if (ret)
>> +               return ret;
>> +
>> +       ret = mcp_write_pairing_set();
>> +       if (ret) {
>> +               pr_err("MCP: Unable to disable write pairing!\n");
>> +               return ret;
> 
> The return value isn't used in patch 3.  Is there a point to returning
> an error from this function in either of the above two locations,
> considering that?
> 
> Looks good otherwise.
> 
> Acked-by: Gregory Fong <gregory.0xf0@xxxxxxxxx>

Not really, how about this:

void __init brcmstb_biuctrl_init(void)
{
        int ret;

        setup_hifcpubiuctrl_regs();

        ret = mcp_write_pairing_set();
        if (ret) {
                pr_err("MCP: Unable to disable write pairing!\n");
                return;
        }

#ifdef CONFIG_PM_SLEEP
        register_syscore_ops(&brcmstb_cpu_credit_syscore_ops);
#endif
}

and updating the function prototype accordingly in the header file?
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html