On Thu, 3 Sep 2015 10:32:45 +0200 Alban <albeu@xxxxxxx> wrote: > > -IRQCHIP_DECLARE(ath79_misc_intc, "qca,ar7100-misc-intc", > > - ath79_misc_intc_of_init); > > + > > +static int __init ar7100_misc_intc_of_init( > > + struct device_node *node, struct device_node *parent) > > +{ > > + pr_info("IRQ: Setup ar7100 misc IRQ controller from > > devicetree.\n"); > > Debug left over? I'll remove it in next patch. I added it because you mentioned a log message in your last review. > On Mon, 10 Aug 2015 20:11:14 +0200 > Alban <albeu@xxxxxxx> wrote: >> Mon, 10 Aug 2015 20:11:14 +0200 >> A log message would be nice. IMHO it should mention that the ACK >> callbacks have been missed when introducing OF support.
Attachment:
pgpLG2pktDwY5.pgp
Description: OpenPGP digital signature