On 09/08/2015 10:18 AM, Ezequiel Garcia wrote: > On 8 September 2015 at 08:53, Jagan Teki <jteki@xxxxxxxxxxxx> wrote: >> On 8 September 2015 at 15:19, Bayi Cheng <bayi.cheng@xxxxxxxxxxxx> wrote: >>> Add Mediatek nor flash node >>> >>> Signed-off-by: Bayi Cheng <bayi.cheng@xxxxxxxxxxxx> >>> --- >>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> index d18ee42..a14f005 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >>> @@ -365,6 +365,16 @@ >>> status = "disabled"; >>> }; >>> >>> + nor_flash: nor@1100d000 { >> >> Based on the comments from 1/3 - this notation needs to be change something like >> qspi0: quadspi@1100d000 >> > > Actually, to follow ePAPR recomendations it should be named as flash@1100d000. > (See ePAPR, 2.2.2 Generic Names Recommendation). The flash device node should, but this is the controller which should be "spi" IMO even if this is not a general purpose controller. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html