On Thu, Aug 20, 2015 at 01:29:40AM +0200, Javier Martinez Canillas wrote:
> Hello Brian,
>
> [...]
>
> > +
> > +&rk808 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pmic_int_l &dvs_1 &dvs_2>;
> > + dvs-gpios = <&gpio7 12 GPIO_ACTIVE_HIGH>,
> > + <&gpio7 15 GPIO_ACTIVE_HIGH>;
>
> I see the dvs-gpios DT property is documented in the downstream
> ChromiumOS 3.18 tree [0] but I don't see it neither mentioned in
> Documentation/devicetree/bindings/mfd/rk808.txt in mainline nor code
> that parses it in the drivers/regulator/rk808-regulator.c driver.
Good catch.
> So I think this should be removed and also the dvs_{1,2} pinctrl
> lines.
OK, will do. I see that jerry, minnie, and speedy also have the pinctrl
lines. Should they be killed as well?
> The rest of the patch looks good to me though so with these
> removed feel free to add:
>
> Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
Thanks.
> [0]: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14/Documentation/devicetree/bindings/mfd/rk808.txt
Brian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
