On 23/08/15 15:17, Vinod Koul wrote: > On Tue, Aug 18, 2015 at 02:49:09PM +0100, Jon Hunter wrote: > >> @@ -1543,7 +1531,7 @@ static int tegra_dma_pm_suspend(struct device *dev) >> int ret; >> >> /* Enable clock before accessing register */ >> - ret = tegra_dma_runtime_resume(dev); >> + ret = pm_runtime_get_sync(dev); > > why is this required ? Because the clock could be disabled when this function is called. This function saves the DMA context so that if the context is lost during suspend, it can be restored. Cheers Jon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html