Hello, Ping? - Sanchayan. On 15-08-05 14:25:48, Sanchayan Maity wrote: > Hello, > > The patchset adds support for 4 wire touchscreen on Toradex Colibri > VF50 modules. Patches are tested on top of shawn's for-next branch. > > Changes since v2: > 1. Fix pin multiplexing for pins in idle state. Configuration of the > pen detect pull up viz. PTA19__GPIO_9 resulted in generation of pen > irq's on a continuous basis. > 2. Fix pinmux of the ADC pins as per the recommended pinmux in TRM. > 3. Use a threaded irq handler instead of a irq handler plus workqueue > approach. > 4. Use a low level trigger with oneshot flag specifier instead of the > previous falling edge triggered irq's. This coupled with the fix in > point 1 fixes the previous continuous spurious irq generation bug. > 5. Change/fix the TS measurement logic to account for the fact that > iio_channel_read_raw might actually return an error. To be more > specific use break instead of continue and take care to close the > FET's in case of channel read error. > 6. Drop the first patch "Add io-channel-cells property for ADC node" > as it has already been applied. > 7. Move the iio channel get call again at the start. Having it in > the end resulted in crashes sometimes when iio was not probed and > the ts device got probed and opened earlier. > > Changes since v1: > 1. Fix/drop comments > 2. Use an inline function for multiple gpiod_get calls in probe > 3. Remove the pull up in the pinmux specified in DT for touchctrl_gpios > 4. Add the io-channel-cells property before status property. > 5. Add GPIOLIB as dependency in the Kconfig file > > Version 2 of the patchset can be found here > https://www.mail-archive.com/linux-input@xxxxxxxxxxxxxxx/msg18090.html > > Version 1 of the patchset can be found here > https://lkml.org/lkml/2015/6/30/103 > > Thank you very much for the feedback till now. > > Regards, > Sanchayan. > > Sanchayan Maity (3): > ARM: dts: vf500-colibri: Add device tree node for touchscreen support > input: Add DT binding documentation for Colibri VF50 touchscreen > touchscreen: colibri-vf50-ts: Add touchscreen support for Colibri VF50 > > .../bindings/input/touchscreen/colibri-vf50-ts.txt | 32 ++ > arch/arm/boot/dts/vf500-colibri-eval-v3.dts | 4 + > arch/arm/boot/dts/vf500-colibri.dtsi | 45 +++ > drivers/input/touchscreen/Kconfig | 12 + > drivers/input/touchscreen/Makefile | 1 + > drivers/input/touchscreen/colibri-vf50-ts.c | 404 +++++++++++++++++++++ > 6 files changed, 498 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/colibri-vf50-ts.txt > create mode 100644 drivers/input/touchscreen/colibri-vf50-ts.c > > -- > 2.5.0 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
