Hi, >> I intentional left this code as is so that the driver will still works >> with older version of the EDAC code. > > Huh, what? I don't think this is how upstream development works. I will fix this in next version. > >> I had already reversed the logic for the L3 and SoC. Are you asking >> for the MC/PMD (earlier posting)? The MC/PMD routine isn't that big. >> Functions in general fit in an screen of 80 column? > > Only for the ones where it becomes clumsy and flipping it would make the > code more readable. I'm not a hard 80 cols follower anyway. I will look at the code one more time and see if the code would be better with logic flipped for L2/L1 and MC. > >> So, is there something that I am missing? > > I hope you're not. But seeing the custom debugfs stuff left in the new > submission without any comment as to *why* you've left it, made me think > you didn't incorporate all feedback. -Loc -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
