Hi, On Tuesday 04 August 2015 09:30 PM, Felipe Balbi wrote: > On Tue, Aug 04, 2015 at 08:50:40PM +0530, Kishon Vijay Abraham I wrote: >> No functional change. Add separate functions for pll, >> clocks and syscon to make ti_pipe3_probe clean. >> >> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx> > > I think this needs to be splitted into smaller patches. yeah sure. Thanks Kishon > > Seems like the very first patch would be to introduce a local struct > device pointer to be used. Than add each and every new function on their > own patch. This will help big time making your refactoring a lot clearer > and, should anything go wrong, we can atomically revert a specific > change, instead of loosing the entire refactor. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html