On 05/08/2015 at 13:41:19 +0200, Alexandre Belloni wrote : > Hi, > > On 05/08/2015 at 04:13:17 -0700, Tony Lindgren wrote : > > * Keerthy <j-keerthy@xxxxxx> [150805 03:53]: > > > Based on the board property switch the source from internal > > > to external clock. Switching to external source is needed for > > > rtcwake to work in low power modes. > > > > I think this is better handled based on the compatible string > > in the device driver rather than introducing a custom dts > > property for it. You can just set the quirk flag in the driver > > probe based on the compatible. > > > > Why not use the clocks property? Then you can pass an external clock. If > it is present you can even get its rate if this is needed at some point > in the future. You could also disable it when going to suspend. > Actually, that was already my suggestion back in april: http://patchwork.ozlabs.org/patch/445631/ (Please Cc: the rtc mailing list for RTC related patches so that they get picked up by patchwork). -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
