Re: [PATCH 3/8] rtc: omap: Add external clock enabling support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi,

On 05/08/2015 at 04:13:17 -0700, Tony Lindgren wrote :
> * Keerthy <j-keerthy@xxxxxx> [150805 03:53]:
> > Based on the board property switch the source from internal
> > to external clock. Switching to external source is needed for
> > rtcwake to work in low power modes.
> 
> I think this is better handled based on the compatible string
> in the device driver rather than introducing a custom dts
> property for it. You can just set the quirk flag in the driver
> probe based on the compatible.
> 

Why not use the clocks property? Then you can pass an external clock. If
it is present you can even get its rate if this is needed at some point
in the future. You could also disable it when going to suspend.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux