Philip, Michal, thanks for your reviews. On Tue, Jul 28, 2015 at 1:25 AM, Michal Simek <michal.simek@xxxxxxxxxx> wrote: > On 07/28/2015 10:05 AM, Philipp Zabel wrote: >> Am Freitag, den 24.07.2015, 17:21 -0700 schrieb Moritz Fischer: >>> Signed-off-by: Moritz Fischer <moritz.fischer@xxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/reset/zynq-reset-pl.txt | 13 +++++++++++++ >>> 1 file changed, 13 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/reset/zynq-reset-pl.txt >>> >>> diff --git a/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt b/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt >>> new file mode 100644 >>> index 0000000..ac4499e >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt >>> @@ -0,0 +1,13 @@ >>> +Xilinx Zynq PL Reset Manager >>> + >>> +Required properties: >>> +- compatible: "xlnx,zynq-reset-pl" >>> +- syscon <&slcr>; >>> +- #reset-cells: 1 >>> + >>> +Example: >>> + rstc: rstc@240 { >>> + #reset-cells = <1>; >>> + compatible = "xlnx,zynq-reset-pl"; >>> + syscon = <&slcr>; >> >> Why the syscon phandle if rstc always is the child of slcr? Why not just >> request the syscon for the rstc's parent node. > > We are using this description for pincntrl which was properly reviewed > that's why I expect Moritz just use the same style. > But yes also referencing parent should work. Michal is right, I tried to be consistent with the pinctrl. Either one is fine for me. We'll just have to make a decision :-) > > TBH I don't have strong preference but having unified style is something > what I would prefer. > > Also I see that using parent is used by others and it looks like that > having something like syscon_regmap_lookup_parent will be worth to have. > > Thanks, > Michal > > Moritz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html