On Monday, July 27, 2015 10:56:22 AM James Liao wrote: > Hi Daniel, > > On Fri, 2015-07-24 at 19:32 +0800, Daniel Kurtz wrote: > > > @@ -88,6 +88,13 @@ > > > > > > #clock-cells = <0>; > > > > > > }; > > > > > > + cpum_ck: dummy_clk { > > > > I'm not a big fan of this "dummy_clk". > > The 'name' part of the devicetree node is supposed to be generic. > > So, perhaps just oscillator@2, and move it down below clk32k: > > oscillator@1. > > > Otherwise: > cpum_ck is a test clock which only available in IC test. It's empty on > MT8173 evaluation or production boards. Should we name this kind of > empty clock as an oscillator? Or is there a better name for it? > So if it will never be part of any available boards, why do you want to add it? Regards, Matthias -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html