On Thu, Jul 9, 2015 at 4:47 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Monday 06 July 2015 16:28:43 Duc Dang wrote: > > On Tue, Jun 30, 2015 at 11:22 AM, Duc Dang <dhdang@xxxxxxx> wrote: > > > This patch set adds 1 large (up to 64GB) memory window for each PCIe > > > controller nodes in X-Gene device tree and fix PCIe controller driver > > > to handle multiple memory ranges correctly. These changes are required > > > to support PCIe devices that has huge BAR. > > > > > > v2 changes: > > > 1. Separate device-tree changes and driver changes into different > > > patches > > > 2. Explicitly define new large window as 64-bit prefetchable in dts > > > 3. Use IORESOURCE_PREFETCH flag to determine which PCIe controller > > > register to be used to configure the memory ranges. > > > > > > arch/arm64/boot/dts/apm/apm-storm.dtsi | 23 ++++++++++++++--------- > > > drivers/pci/host/pci-xgene.c | 12 ++++++++++-- > > > 2 files changed, 24 insertions(+), 11 deletions(-) > > > > Hi Arnd, Bjorn, > > > > Do you have additional comment on this v2 patch set? > > > > > > The changes look ok to me now, but I'd mention in the changelog about > the fact that one of the windows is prefetchable and the other one > is not, and that only prefetchable BARs are now using the 64-bit > window. Thanks, Arnd. I posted v3 patch to clarify each PCIe node will have 2 memory windows: 1 non-prefetchable 32-bit memory window and 1 prefetchable 64-bit window > > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Regards, Duc Dang. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
