On Fri, Jun 19, 2015 at 11:25:57AM +0900, Chanwoo Choi wrote:
> Hi Charles,
>
> On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax
> <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > This patch adds bindings for the basic microphone detection platform
> > data.
> >
> > Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> > ---
> > + dbtime = 0;
> > + device_property_read_u32(arizona->dev, "wlf,micd-dbtime", &dbtime);
> > + switch (dbtime) {
> > + case 2:
>
> I'd like you to define the constant variable for specific integer
> value to improve the readability.
> e.g.,
>
> #define MICD_DBTIME_XXX 2
> #define MICD_DBTIME_XXX 4
>
> > + pdata->micd_dbtime = 0x10000;
>
> Also, you better to define the constant variable for "0x10000" to
> improbe readability in the include/linux/mfd/arizona.h. If you just
> use the hex value, the other developer cannot analyze the meaning of
> "0x10000".
>
> > + break;
> > + case 4:
>
> ditto.
>
I am not sure these two really warrant a define the number in DT
indicates the number of debounces to perform.
#define MICD_DBTIME_TWO 2
switch (dbtime)
case MICD_DBTIME_TWO:
Is if anything less clear than just using 2 directly. I could
perhaps rename the varible to num_debounces instead?
Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
