Hi, >> > +static int edac_mc_idx; >> > +static int edac_mc_active_mask; >> > +static int edac_mc_registered_mask; >> > +static DEFINE_MUTEX(xgene_edac_mc_lock); >> >> It would also be best to avoid global variables, but it seems that at >> least the edac_mc_idx is needed to work with the EDAC subsystem. >> Maybe Boris has an idea for how to avoid it. > > Right, so AFAICT this is used in > > edac_mc_alloc(edac_mc_idx++ > > and basically we're supplying the memory controller numbers in the order > we're calling xgene_edac_mc_add(). Perhaps we need to make the memory > controller numbering explicit with DT... > Let me move them all into the top level driver given that the MC is now a subnode. -Loc -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
