On Monday 18 May 2015 17:24:40 Loc Ho wrote: > + tmp_ctx.mcu_id = ((res.start >> 16) & 0xF) / 4; > Just found this line: you are effectively hardcoding the physical register layout of the chip in the driver here, to get the index of the memory controller. This is a very bad idea as it prevents you from reusing this driver for another chip that puts the same registers in a different place, don't do that. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
