On Wednesday 13 May 2015 17:49:00 Rob Herring wrote: > + > + /* enable port power and reserved bit 25 */ > + status = __raw_readl(&ehci_regs->port_status[0]); > + status |= (PORT_POWER) | (1 << 25); > + /* Clear bits 30:31 for HSIC to be enabled */ > + status &= ~(0x3 << 30); > + __raw_writel(status, &ehci_regs->port_status[0]); > + > + /* test mode: force enable hs */ > + status = __raw_readl(&ehci_regs->port_status[0]); > + status &= ~(0xf << 16); > + status |= (0x5 << 16); > + __raw_writel(status, &ehci_regs->port_status[0]); > + > + /* disable test mode */ > + status = __raw_readl(&ehci_regs->port_status[0]); > + status &= ~(0xf << 16); > + __raw_writel(status, &ehci_regs->port_status[0]); Please make this endian-safe. > + > +static const struct of_device_id mv_ehci_dt_match[] = { > + {.compatible = "marvell,pxa1928-ehci"}, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, mv_ehci_dt_match); > +static struct platform_driver ehci_mv_driver = { > + .probe = mv_ehci_probe, > + .remove = mv_ehci_remove, > + .shutdown = mv_ehci_shutdown, > + .driver = { > + .name = "mv-ehci-of", > + .of_match_table = of_match_ptr(mv_ehci_dt_match), > + }, > +}; Warning: unused symbol 'mv_ehci_dt_match'. Just remove the of_match_ptr(). Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html