On Tue, 12 May 2015 10:31:01 +0200 Paul Bolle <pebolle@xxxxxxxxxx> wrote:
> Just a nit: a license mismatch.
>
> On Mon, 2015-05-11 at 11:56 +1000, NeilBrown wrote:
> > --- /dev/null
> > +++ b/drivers/tty/serial/slave/uart_slave_core.c
>
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
>
> This states the license is GPL v2 or later.
>
> > +MODULE_LICENSE("GPL v2");
>
> And, according to include/linux/module.h, this states the license is
> just GPL v2. So I think either the comment at the top of this file or
> the license ident used in the MODULE_LICENSE() macro needs to change.
>
> Thanks,
>
>
> Paul Bolle
>
Thanks. I've modified the comment to be explicit that only 'version 2' is
appropriate.
NeilBrown
Attachment:
pgp17R6pqRtpa.pgp
Description: OpenPGP digital signature
