On 3/21/25 16:15, Dmitry Baryshkov wrote: > On Fri, Mar 21, 2025 at 03:58:47PM +0200, Ivaylo Ivanov wrote: >> As not only Qualcomm, but also Samsung is using the Synopsys eUSB2 IP >> (albeit with a different register layout) in their newer SoCs, move the >> driver out of its vendor sub-directory and rename it to phy-snps-eusb2. >> >> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx> >> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Please fix the order of the tags. SoB should come after Suggested-by > (and usually it is the last one). Hm? I haven't had issues with SoB at the top in the past. > >> --- >> drivers/phy/Kconfig | 8 ++++++++ >> drivers/phy/Makefile | 1 + >> .../{qualcomm/phy-qcom-snps-eusb2.c => phy-snps-eusb2.c} | 0 >> drivers/phy/qualcomm/Kconfig | 9 --------- >> drivers/phy/qualcomm/Makefile | 1 - >> 5 files changed, 9 insertions(+), 10 deletions(-) >> rename drivers/phy/{qualcomm/phy-qcom-snps-eusb2.c => phy-snps-eusb2.c} (100%) > With that fixed: > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx> Thanks! Best regards, Ivaylo > >